[OPEN-ILS-DEV] PATCH: oils_auth.c (memory leaks)

Scott McKellar mck9 at swbell.net
Sun Feb 24 00:43:05 EST 2008

In oilsAuthGetTimeout() we make three calls to 
osrf_settings_host_value_object(), which allocates a jsonObject.
However we were passing the return values directly to another 
function, without capturing the pointers for freeing.  As a result 
we were leaking the jsonObjects thus allocated.

I rearranged the code to capture the pointers and free each object.

Scott McKellar

Developer's Certificate of Origin 1.1 By making a contribution to
this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license indicated
in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source license
and I have the right under that license to submit that work with
modifications, whether created in whole or in part by me, under the
same open source license (unless I am permitted to submit under a
different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person
who certified (a), (b) or (c) and I have not modified it; and

(d) In the case of each of (a), (b), or (c), I understand and agree
that this project and the contribution are public and that a record
of the contribution (including all personal information I submit
with it, including my sign-off) is maintained indefinitely and may
be redistributed consistent with this project or the open source
license indicated in the file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: oils_auth_c_3.patch
Type: text/x-patch
Size: 1710 bytes
Desc: 4288977400-oils_auth_c_3.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20080223/aa38b9aa/oils_auth_c_3-0001.bin

More information about the Open-ils-dev mailing list